Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874249 --- Comment #6 from Darryl L. Pierce <dpierce@xxxxxxxxxx> --- (In reply to comment #5) > For -1.1: > > * Versioning > - Please don't use ".1" for release unless needed. > Please use just integer (and %{?dist}) > c.f. > > https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning > > * License > - README.md says that this is under MIT. Fixed. > * Documentation > - Current ruby guideline says test/ directory should not be > shipped in binary rpm > > https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/ > Ruby#Running_test_suites Hrm, that should be in the -doc package. Looking in the packages built the test directory is with the docs, per the specfile. > - Also, "Rakefile" is something like Makefile, which is usually not > not needed for binary rpm. Same here. > * Enabling test suite > - As this package contains test/ directory, please execute > some tests in %check (like ruby -Ilib test/test_inifile.rb) Their tests require a separate gem be installed called bones. I would prefer not to package that as it's not useful to me and isn't a runtime requirement for inifile. Updated SPEC: http://mcpierce.fedorapeople.org/rpms/rubygem-inifile.spec Updated SRPM: http://mcpierce.fedorapeople.org/rpms/rubygem-inifile-2.0.2-1.2.fc17.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4796678 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fTWgLWnHbr&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review