Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874249 --- Comment #5 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- For -1.1: * Versioning - Please don't use ".1" for release unless needed. Please use just integer (and %{?dist}) c.f. https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning * License - README.md says that this is under MIT. * Documentation - Current ruby guideline says test/ directory should not be shipped in binary rpm https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites - Also, "Rakefile" is something like Makefile, which is usually not not needed for binary rpm. * Enabling test suite - As this package contains test/ directory, please execute some tests in %check (like ruby -Ilib test/test_inifile.rb) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4PQxqhMVOt&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review