Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874249 --- Comment #8 from Darryl L. Pierce <dpierce@xxxxxxxxxx> --- (In reply to comment #7) > (In reply to comment #6) > > > * Enabling test suite > > > - As this package contains test/ directory, please execute > > > some tests in %check (like ruby -Ilib test/test_inifile.rb) > > > > Their tests require a separate gem be installed called bones. I would prefer > > not to package that as it's not useful to me and isn't a runtime requirement > > for inifile. > > - That is needed when you try to execute test suite using rake > (bones is used only in Rakefile). See: > > https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/ > Ruby#Running_test_suites > the line "The tests should not be run using Rake". As I said before, > it seems that "ruby -Ilib test/test_inifile.rb" does some test > program, so please consider to enable %check section. One of the author's tests is consistently failing. I will work with the upstream to fix this, and will enable tests after that is done. Since they're not required, this shouldn't be considered a blocker. > > > > * Documentation > > > - Current ruby guideline says test/ directory should not be > > > shipped in binary rpm > > > > > > https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/ > > > Ruby#Running_test_suites > > > > Hrm, that should be in the -doc package. Looking in the packages built the > > test directory is with the docs, per the specfile. > > - So the current guideline says test/ directory should not be > included also in -doc subpackage (see "Do not ship tests" in > > https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/ > Ruby#Running_test_suites ) > (If you think test/ directory in this gem is useful for users, > I won't treat this as a blocker) The tests and Rakefile are no longer shipping with either package. Updated SPEC: http://mcpierce.fedorapeople.org/rpms/rubygem-inifile.spec Updated SRPM: http://mcpierce.fedorapeople.org/rpms/rubygem-inifile-2.0.2-1.3.fc17.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4802664 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UbYFugvaWk&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review