Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874105 --- Comment #4 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- For 0.2-2: * Summary - "Proton is a " on summary is redundant. It is included in Name. * BuildRequires - ruby-devel: Currently ruby related things are not included in generated binary rpm. Would you check if BR: ruby-devel is really needed? (Or is it possible to enable ruby binding?) * Touching %buildroot in prep - "mkdir -p %{buildroot}%{_mandir}" in prep does nothing because %buildroot is always removed at the beginning of %install. * Possibly unneeded commands - Is 'echo "_mandir==%{_mandir}"' in install really needed? ! %defattr (not a blocker) https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_Permissions - %defattr is now not explicitly needed. * Dependency between subpackages https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Requiring_Base_Package - Usually dependency between main <-> sub-packages should be (Epoch)-Version- Release.arch specific. i.e. usually Requires: %{name}%{?_isa} = %{version}-%{release} is needed (also in -devel subpackage). * Files in -devel packages https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Devel_Packages - Unversioned %{_libdir}/libqpid-proton.so should usually be in -devel subpackage, not in main package. - Would you check if %_includedir/proton/cproton.i is really needed? * Directory ownership issue https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_and_Directory_Ownership - Please make it sure that directories created when installing binary rpms are correctly owned by the appropriate rpms. Currently the following directories are left unowned. %{proton_datadir}/ %{proton_datadir}/docs/ %{proton_datadir}/docs/api-c/ %{proton_datadir}/docs/api-py/ %{_includedir}/proton/ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eI8VTlxMI9&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review