Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874105 --- Comment #5 from Darryl L. Pierce <dpierce@xxxxxxxxxx> --- (In reply to comment #4) > For 0.2-2: > > * Summary > - "Proton is a " on summary is redundant. It is included in Name. Removed. > * BuildRequires > - ruby-devel: > Currently ruby related things are not included in generated > binary rpm. Would you check if BR: ruby-devel is really needed? > (Or is it possible to enable ruby binding?) We have a Ruby gem for Proton that will be proposed as a separate package. > * Touching %buildroot in prep > - "mkdir -p %{buildroot}%{_mandir}" in prep does nothing because > %buildroot is always removed at the beginning of %install. Removed. > * Possibly unneeded commands > - Is 'echo "_mandir==%{_mandir}"' in install really needed? No, that's an artifact from when I was writing the spec. I've removed it now. > ! %defattr (not a blocker) > > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#File_Permissions > - %defattr is now not explicitly needed. > > * Dependency between subpackages > > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#Requiring_Base_Package > - Usually dependency between main <-> sub-packages should be > (Epoch)-Version- > Release.arch specific. i.e. usually Requires: %{name}%{?_isa} = > %{version}-%{release} > is needed (also in -devel subpackage). Fixed. Thanks for catching that. > * Files in -devel packages > > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#Devel_Packages > - Unversioned %{_libdir}/libqpid-proton.so should usually be in -devel > subpackage, not in main package. Fixed. > - Would you check if %_includedir/proton/cproton.i is really needed? It is for anybody who wants to write language bindings for Proton. > * Directory ownership issue > > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#File_and_Directory_Ownership > - Please make it sure that directories created when installing > binary rpms are correctly owned by the appropriate rpms. > Currently the following directories are left unowned. > > %{proton_datadir}/ > %{proton_datadir}/docs/ > %{proton_datadir}/docs/api-c/ > %{proton_datadir}/docs/api-py/ > %{_includedir}/proton/ Should be done. Updated SPEC: http://mcpierce.fedorapeople.org/rpms/qpid-proton.spec Updated SRPM: http://mcpierce.fedorapeople.org/rpms/qpid-proton-0.2-2.1.fc17.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4788015 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3iv12VecFQ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review