Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836368 --- Comment #9 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- For 0.0.6-2: ! bug dependency - As this bug depends on 836368, I cannot approve this bug until bug 836368 is updated. * About C extension related things - This package is noarch, no C code is included, so C extension related things are not needed. (e.g. export CONFIGURE_ARGS=.... writing this on noarch srpm is confusing) * Unneeded files - https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites - Current packaging guidelines requests NOT to ship files under test/ - Also, "Rakefile" is something like "Makefile", which we do not ship in binary rpms. - %{gem_instdir}/bicho.gemspec is usually also not needed. * Executing test https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites - As this gem contains test/ directory, please execute some test suite on %check if possible. If not possible, please write some comments on the spec file (e.g. test suite needs network access or so) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ok0OzCxpTs&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review