Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876865 --- Comment #5 from Terje Røsten <terjeros@xxxxxxxxxxxx> --- Thanks for updates! Some more: rpmlint issues: brewtarget.x86_64: W: invalid-license WTFPLv2 brewtarget.x86_64: W: invalid-license LGPLv2.1 According to https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Software_License_List the correct short names are LGPLv2+ and WTFPL brewtarget.x86_64: W: no-manual-page-for-binary brewtarget There is in fact a man page available in brewtarget-1.2.5/doc/brewtarget.1 Add that by doing e.g. in %install install -D 0644 doc/brewtarget.1 ${buildroot}%{_mandir}/man1/brewtarget.1 and %{_mandir}/man1/brewtarget.1* in %files. Pedantic space and empty lines hang ups: - no empty lines before %description - remove leading space in make %{?_smp_mflags} line - just a single empty line before %install and %changelog - one empty line between each item in %changelog BTW: the reason for %{version} in source0 is to avoid trouble when updating version and forgetting to update source0, you only need it the filename, not in the url. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review