Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=860249 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@xxxxxx --- Comment #25 from Jussi Lehtola <jussi.lehtola@xxxxxx> --- (In reply to comment #24) > You have `rm -fr %{buildroot}` in both %install and %clean. You shouldn't > have to do this in either section. Although this is done automatically by newer versions of RPM, it's in no sense wrong to do it. > You are missing a %files section. The package should claim ownership of > every file it installs here. By convention, %doc should also be in this > section. Nope, doesn't apply to fonts. See https://fedoraproject.org/wiki/Packaging:FontsPolicy https://fedoraproject.org/wiki/Simple_fonts_spec_template The %files section is already provided by the %_font_pkg macro. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review