Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=860249 Pete Travis <me@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |me@xxxxxxxxxxxxxx --- Comment #24 from Pete Travis <me@xxxxxxxxxxxxxx> --- Hey Tobias, I have a couple informal comments to offer: The package and spec file pass rpmlint, and the font looks great! I don't see where I can download Source1, %{name}-fontconfig.conf . Is this publicly available? You have `rm -fr %{buildroot}` in both %install and %clean. You shouldn't have to do this in either section. You are missing a %files section. The package should claim ownership of every file it installs here. By convention, %doc should also be in this section. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review