Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876865 --- Comment #4 from Pete Travis <me@xxxxxxxxxxxxxx> --- (In reply to comment #2) > Some more: > > * use %{version} in source url This seems a bit excessive. It would break validation tools, and require users trying to download the source tarball to manually substitute in the version number. > * ctest don't seems to do anything useful, remove Following http://fedoraproject.org/wiki/Packaging:Cmake here. I'm not familiar with cmake, so I'll take your word for it, thanks. Removed empty %clean section. > * no need for %{_docdir}/%{name}-%{version} in %files Fixed. > * app seems to ship mp3 files, that might be a problem I agree it isn't ideal, but several other packages are shipping mp3 files. I can test to verify the application functions if there is no decoder. Thanks for your comments, Terje! I also corrected the following issues: - Included two license documents in %doc that were shipped from upstream, - disposed of the superfluous `rm -rf %{_docdir}/%{name}-%{version}/*` in %install, this was leftover from before the related patch. Updated files are: SPEC: http://randomuser.org/brewtarget/brewtarget.spec SRPM: http://randomuser.org/brewtarget/brewtarget-1.2.5-2.fc17.src.rpm Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=4697931 -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review