Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876865 --- Comment #3 from Pete Travis <me@xxxxxxxxxxxxxx> --- (In reply to comment #1) > Some comments: > > * I am confused by your release tag usage, why the rc prefix and why not > increase on update? > > Please consult: > https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag > It seemed appropriate, because the package has not been released in Fedora but is a candidate for it. I see the convention is to follow upstream's release canidates here, corrected. > * why are " pairs used in license tag? A syntax error on my part, corrected. > * consider to use one line for each buildreq. Done. > * validate the desktop file during install Done. > * add empty line before %check Done. > * add space after * in %changelog Done. I see I missed an entry here for Patch2, adding it now. > * use VERBOSE=1 in make to verify options used when building Done. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review