Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=819951 Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #22 from Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> --- (In reply to comment #21) > Thanks for the review! And the changes look good -- APPROVED > > [!]: If the package is under multiple licenses, the licensing breakdown must > > be documented in the spec. > > Fixed...though this sort of text is exactly what the COPYING file in the > upstream source code is attempting to describe. > True, though as COPYING is often just the GPL text, it helps to have a comment pointing out where such a documentation can be found. > > [!]: Spec use %global instead of %define. > > Note: %define enable_embedded_dependencies 0 %define build_name ostree- > > embeddeps %define build_name ostree %define embedded_dependencies_option > > --enable-embedded-dependencies %define embedded_dependencies_option > > %{nil} > > Fixed (I think). Where is this guideline? > Yup; here: http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review