https://bugzilla.redhat.com/show_bug.cgi?id=819951 --- Comment #21 from Colin Walters <walters@xxxxxxxxxx> --- Thanks for the review! (In reply to comment #20) > [!]: Package installs properly. > Red herring - linux-user-chroot is not pushed to F-18 yet. > When releasing this, both should be pushed out in the same update > Note: Installation errors (see attachment) > See: https://fedoraproject.org/wiki/Packaging:Guidelines Ok, will do. > [!]: If (and only if) the source package includes the text of the license(s) > in its own file, then that file, containing the text of the license(s) > for the package is included in %doc. > > The COPYING* files must, and README.md and TODO files should, be > listed as %doc Fixed. > [!]: If the package is under multiple licenses, the licensing breakdown must > be documented in the spec. Fixed...though this sort of text is exactly what the COPYING file in the upstream source code is attempting to describe. > [!]: Spec use %global instead of %define. > Note: %define enable_embedded_dependencies 0 %define build_name ostree- > embeddeps %define build_name ostree %define embedded_dependencies_option > --enable-embedded-dependencies %define embedded_dependencies_option > %{nil} Fixed (I think). Where is this guideline? New spec: http://fedorapeople.org/~walters/ostree/ostree.spec New SRPM: http://fedorapeople.org/~walters/ostree/ostree-2012.12-1.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review