Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876865 Terje Røsten <terjeros@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |terjeros@xxxxxxxxxxxx --- Comment #1 from Terje Røsten <terjeros@xxxxxxxxxxxx> --- Some comments: * I am confused by your release tag usage, why the rc prefix and why not increase on update? Please consult: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag * why are " pairs used in license tag? * consider to use one line for each buildreq. * validate the desktop file during install * add empty line before %check * add space after * in %changelog * use VERBOSE=1 in make to verify options used when building -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review