https://bugzilla.redhat.com/show_bug.cgi?id=844070 Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |AlsaMixer.app - Simple |alsamixer-dockapp - Simple |mixer application for ALSA |mixer application for ALSA |drivers |drivers Alias| |alsamixer-dockapp --- Comment #3 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/alsamixer-dockapp.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/alsamixer-dockapp-0.1-2.fc17.src.rpm I've renamed the package to avoid the period and use a more common style (not capitalized). Morevover, a symlink is now present which points from alsamixer-dockapp to the original binary. (In reply to comment #2) > - According to the guidelines, package names must not contain periods. I > suggest to replace it with a dash. => AlsaMixer-app > http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Separators > > - The spec filename has a trailing tilde that should be dropped. > > - Replace the tab characters in the BuildRequires lines with spaces to make > rpmlint happy (see below). > Done. > - If upstream is still alive, please ask them to update the FSF address in > COPYING and the source files. > Impossible. Upstream is dead for ages, as usual for a lot of dockapp packages. > - gcc reports several warnings about deprecated non-const char pointer > initializations: > warning: deprecated conversion from string constant to 'char*' > [-Wwrite-strings] > > Future versions of gcc might drop support for this. Thus, I recommend to > patch the sources by adding the missing "const" modifier before "char*". > That's not a blocker, though. I've no programming skills... Do you mean: int main(int argc, const char** argv) instead of the current: int main(int argc, char** argv) > [.] SHOULD: Your package should contain man pages for binaries/scripts. What about to adding a man page? I've created one from the --help output with help2man. Needs some love, but could be more convenient for users. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review