https://bugzilla.redhat.com/show_bug.cgi?id=832666 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |rdieter@xxxxxxxxxxxx Flags| |fedora-review? --- Comment #7 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- $ rpmlint kfaenza-icon-theme.spec kfaenza-icon-theme.spec: W: no-%build-section 0 packages and 1 specfiles checked; 0 errors, 1 warnings. naming: ok 1. SHOULD drop index.patch, I don't think it's helpful. Looks like faenza actually installs as Faenza ondisk, and the other inherits look legit to me. 2. MUST drop -f from gtk-update-icon-cache scriptlet calls (the guidelines were recently fixed to not include that) 3. SHOULD drop deprecated/unused .spec tags, including: Group: 4. SHOULD drop BuildRequires: gtk2 >= 2.6.0 doesn't look like it's used or needed here (if it is, please document why in the .spec) 5. SHOULD ping upstream to include licensing information/file in their source tarball 6. SHOULD consider using the included INSTALL script in some form. it looks like it creates a bunch of compatibiliy symlinks for various things -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review