https://bugzilla.redhat.com/show_bug.cgi?id=844070 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #623502| |review+ Flags| | --- Comment #4 from Martin Gieseking <martin.gieseking@xxxxxx> --- Created attachment 623502 --> https://bugzilla.redhat.com/attachment.cgi?id=623502&action=edit removes gcc warnings about conversions from const char* to char* (In reply to comment #3) > Impossible. Upstream is dead for ages, as usual for a lot of dockapp > packages. OK, then we can leave the files as it is. > > Future versions of gcc might drop support for this. Thus, I recommend to > > patch the sources by adding the missing "const" modifier before "char*". > > That's not a blocker, though. > > I've no programming skills... Right, sorry. I've attached a simple patch that adds the const modifiers and const_cast operators where necessary so that the warnings go away. > What about to adding a man page? I've created one from the --help output > with help2man. Needs some love, but could be more convenient for users. Yes, a manpage documenting the command-line options would be nice. Everything else looks good now so that we can finish here. ---------------- Package APPROVED ---------------- -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review