https://bugzilla.redhat.com/show_bug.cgi?id=856238 --- Comment #7 from Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> --- Three issues stand out as needing to be fixed: - Scratch.image bundled by upstream is shipped in the binary RPMs without being regenerated - License field should be of the form "X and Y and Z". A breakdown of which components fall under which license, in a comment above the license field would be nice esp if it's not the case that the license applies cleanly to a whole subpackage - Desktop file needs to be validated and/or installed properly; icon cache needs to be refreshed Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== C/C++ ==== [x]: MUST Header files in -devel subpackage, if present. [x]: MUST Package does not contain any libtool archives (.la) [x]: MUST Package does not contain kernel modules. [x]: MUST Package contains no static executables. [x]: MUST Rpath absent or only used for internal libs. ==== Generic ==== [x]: EXTRA Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: EXTRA Spec file according to URL is the same as in SRPM. [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [!]: MUST Package contains no bundled libraries. Is there any reason Scratch.image is not regenerated, but the bundled one from the source tarball used? [x]: MUST Changelog in prescribed format. [x]: MUST Sources contain only permissible code or content. [!]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files squeak-cameraplugin section. This is OK if packaging for EPEL5. Otherwise not needed [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package contains desktop file if it is a GUI application. [!]: MUST Package installs a %{name}.desktop using desktop-file-install if there is such a file. Don't just copy the desktop file by hand [-]: MUST Development files must be in a -devel package [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Fully versioned dependency in subpackages, if present. [!]: MUST Package complies to the Packaging Guidelines Icon cache must be refreshed, else after the installation the Scratch launcher won't have a proper icon yet: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 [-]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [!]: MUST License field in the package spec file matches the actual license. Licenses should be separated by "and" -- GPLv2 and MIT and CC-BY-SA Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)" For detailed output of licensecheck see file: /home/michel/sources/fedora/projects/FedoraReview/src/856238-scratch/licensecheck.txt [x]: MUST License file installed when any subpackage combination is installed. [!]: MUST Package consistently uses macro is (instead of hard-coded directory names). Note: Using both %{buildroot} and $RPM_BUILD_ROOT [!]: MUST If the package is under multiple licenses, the licensing breakdown must be documented in the spec. Please describe in a comment which parts are under which licenses [x]: MUST Package is named using only allowed ascii characters. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [-]: MUST If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Package is not relocatable. [x]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains systemd file(s) if in need. [x]: MUST File names are valid UTF-8. [x]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [!]: SHOULD Buildroot is not present Note: Buildroot is not needed unless packager plans to package for EPEL5 [!]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean is needed only if supporting EPEL5 [-]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [-]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: SHOULD SourceX tarball generation or download is documented. [x]: SHOULD SourceX / PatchY prefixed with %{name}. [x]: SHOULD SourceX is a working URL. [-]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: SHOULD Package should compile and build into binary rpms on all supported architectures. [!]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: [!]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files squeak-cameraplugin section. This is OK if packaging for EPEL5. Otherwise not needed See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions [!]: MUST Package installs a %{name}.desktop using desktop-file-install if there is such a file. See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 See: None [!]: MUST Package consistently uses macro is (instead of hard-coded directory names). Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros Rpmlint ------- Checking: scratch-squeak-wedoplugin-1.4.0.7-1.fc17.x86_64.rpm scratch-squeak-cameraplugin-1.4.0.7-1.fc17.x86_64.rpm scratch-projects-1.4.0.7-1.fc17.noarch.rpm scratch-help-1.4.0.7-1.fc17.noarch.rpm scratch-debuginfo-1.4.0.7-1.fc17.x86_64.rpm scratch-media-1.4.0.7-1.fc17.noarch.rpm scratch-1.4.0.7-1.fc17.x86_64.rpm scratch-1.4.0.7-1.fc17.src.rpm scratch-image-1.4.0.7-1.fc17.noarch.rpm scratch-squeak-unicodeplugin-1.4.0.7-1.fc17.x86_64.rpm scratch-squeak-scratchplugin-1.4.0.7-1.fc17.x86_64.rpm scratch-i18n-1.4.0.7-1.fc17.noarch.rpm scratch-squeak-cameraplugin.x86_64: W: spelling-error Summary(en_US) webcams -> web cams, web-cams, webmaster scratch-squeak-cameraplugin.x86_64: W: spelling-error %description -l en_US webcams -> web cams, web-cams, webmaster scratch-squeak-cameraplugin.x86_64: W: spelling-error %description -l en_US webcam -> web cam, web-cam, became scratch-debuginfo.x86_64: W: invalid-license GPLv2, MIT, scratch.x86_64: W: spelling-error %description -l en_US subpackages -> sub packages, sub-packages, prepackages scratch.x86_64: W: invalid-license GPLv2, MIT, scratch.x86_64: E: no-binary scratch.src: W: spelling-error %description -l en_US subpackages -> sub packages, sub-packages, prepackages scratch.src: W: invalid-license GPLv2, MIT, scratch.src:159: W: macro-in-comment %{buildroot} scratch.src:159: W: macro-in-comment %{_libdir} scratch.src:159: W: macro-in-comment %{name} 12 packages and 0 specfiles checked; 1 errors, 11 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint scratch-squeak-scratchplugin scratch-help scratch-im age scratch-media scratch-squeak-cameraplugin scratch-squeak-cameraplugin.x86_64: W: spelling-error Summary(en_US) webcams -> web cams, web-cams, webmaster scratch-squeak-cameraplugin.x86_64: W: spelling-error %description -l en_US webcams -> web cams, web-cams, webmaster scratch-squeak-cameraplugin.x86_64: W: spelling-error %description -l en_US webcam -> web cam, web-cam, became 5 packages and 0 specfiles checked; 0 errors, 3 warnings. # echo 'rpmlint-done:' Requires -------- scratch-squeak-wedoplugin-1.4.0.7-1.fc17.x86_64.rpm (rpmlib, GLIBC filtered): libc.so.6()(64bit) rtld(GNU_HASH) scratch-squeak-cameraplugin-1.4.0.7-1.fc17.x86_64.rpm (rpmlib, GLIBC filtered): libc.so.6()(64bit) rtld(GNU_HASH) scratch-projects-1.4.0.7-1.fc17.noarch.rpm (rpmlib, GLIBC filtered): scratch-help-1.4.0.7-1.fc17.noarch.rpm (rpmlib, GLIBC filtered): scratch-debuginfo-1.4.0.7-1.fc17.x86_64.rpm (rpmlib, GLIBC filtered): scratch-media-1.4.0.7-1.fc17.noarch.rpm (rpmlib, GLIBC filtered): scratch-1.4.0.7-1.fc17.x86_64.rpm (rpmlib, GLIBC filtered): scratch-help scratch-i18n scratch-image scratch-media scratch-projects scratch-squeak-cameraplugin scratch-squeak-scratchplugin scratch-squeak-unicodeplugin scratch-squeak-wedoplugin scratch-image-1.4.0.7-1.fc17.noarch.rpm (rpmlib, GLIBC filtered): /bin/sh squeak-vm scratch-squeak-unicodeplugin-1.4.0.7-1.fc17.x86_64.rpm (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcairo.so.2()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) rtld(GNU_HASH) scratch-squeak-scratchplugin-1.4.0.7-1.fc17.x86_64.rpm (rpmlib, GLIBC filtered): libc.so.6()(64bit) rtld(GNU_HASH) scratch-i18n-1.4.0.7-1.fc17.noarch.rpm (rpmlib, GLIBC filtered): Provides -------- scratch-squeak-wedoplugin-1.4.0.7-1.fc17.x86_64.rpm: WeDoPlugin()(64bit) scratch-squeak-wedoplugin = 1.4.0.7-1.fc17 scratch-squeak-wedoplugin(x86-64) = 1.4.0.7-1.fc17 scratch-squeak-cameraplugin-1.4.0.7-1.fc17.x86_64.rpm: CameraPlugin()(64bit) scratch-squeak-cameraplugin = 1.4.0.7-1.fc17 scratch-squeak-cameraplugin(x86-64) = 1.4.0.7-1.fc17 scratch-projects-1.4.0.7-1.fc17.noarch.rpm: scratch-projects = 1.4.0.7-1.fc17 scratch-help-1.4.0.7-1.fc17.noarch.rpm: scratch-help = 1.4.0.7-1.fc17 scratch-debuginfo-1.4.0.7-1.fc17.x86_64.rpm: scratch-debuginfo = 1.4.0.7-1.fc17 scratch-debuginfo(x86-64) = 1.4.0.7-1.fc17 scratch-media-1.4.0.7-1.fc17.noarch.rpm: scratch-media = 1.4.0.7-1.fc17 scratch-1.4.0.7-1.fc17.x86_64.rpm: scratch = 1.4.0.7-1.fc17 scratch(x86-64) = 1.4.0.7-1.fc17 scratch-image-1.4.0.7-1.fc17.noarch.rpm: mimehandler(application/x-scratch-project) scratch-image = 1.4.0.7-1.fc17 scratch-squeak-unicodeplugin-1.4.0.7-1.fc17.x86_64.rpm: UnicodePlugin()(64bit) scratch-squeak-unicodeplugin = 1.4.0.7-1.fc17 scratch-squeak-unicodeplugin(x86-64) = 1.4.0.7-1.fc17 scratch-squeak-scratchplugin-1.4.0.7-1.fc17.x86_64.rpm: ScratchPlugin()(64bit) scratch-squeak-scratchplugin = 1.4.0.7-1.fc17 scratch-squeak-scratchplugin(x86-64) = 1.4.0.7-1.fc17 scratch-i18n-1.4.0.7-1.fc17.noarch.rpm: scratch-i18n = 1.4.0.7-1.fc17 MD5-sum check ------------- http://download.scratch.mit.edu/scratch-1.4.0.7.src.tar.gz : CHECKSUM(SHA256) this package : b94d89278ecef2ba2d1147eec23936dd99697293ffa2c216c0a375ba98226a3e CHECKSUM(SHA256) upstream package : b94d89278ecef2ba2d1147eec23936dd99697293ffa2c216c0a375ba98226a3e Generated by fedora-review 0.2.0 (2fb2447) last change: 2012-07-22 Command line :./fedora-review -b 856238 -m fedora-17-x86_64 External plugins: -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review