Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: adaptx https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225238 ------- Additional Comments From dbhole@xxxxxxxxxx 2007-02-10 17:29 EST ------- Thanks for the comments. I have updated the spec file and the srpm on the given URL above. I fixed the buildroot name, changed license to BSD, removed the commented build-classpath line, expanded the summary a bit, updated source location to the svn tag, and made the BR and Requires same (except for ant, which is strictly a BR). 1. I did not change the RHCLEAN. This is because I am unsure if it is really okay to put jars in tarballs. That used to be the case in Fedora packages before, and gbenson had updated all tarballs to remove the jars. Has the policy changed again? 2. I did not remove the epoch. I don't recall why that exists there in the first place, but I remember fnasser mentioning that it was necessary for packages to work correctly. I will send him a mail asking about this. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review