Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: adaptx https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225238 ------- Additional Comments From overholt@xxxxxxxxxx 2007-02-11 18:45 EST ------- (In reply to comment #5) > 1. I did not change the RHCLEAN. This is because I am unsure if it is really > okay to put jars in tarballs. That used to be the case in Fedora packages > before, and gbenson had updated all tarballs to remove the jars. Has the policy > changed again? I don't think that was ever an official policy. We really shouldn't be mucking with the drops unless there's some legal reason (encryption or closed source) to do so. In this case, if you don't want to ship the binary jars, just add the removing of them to the steps used to make the tarball. Drop the RHCLEAN. > 2. I did not remove the epoch. I don't recall why that exists there in the first > place, but I remember fnasser mentioning that it was necessary for packages to > work correctly. I will send him a mail asking about this. This is a JPackage thing to deal with older, broken RPMs. It's not strictly against the guidelines but it's unnecessary. I won't hold up the review on it, though. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review