https://bugzilla.redhat.com/show_bug.cgi?id=844817 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |tcallawa@xxxxxxxxxx Flags| |fedora-review+ --- Comment #8 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> --- = REVIEW = - rpmlint returns: rubygem-openshift-origin-dns-bind.noarch: W: wrong-file-end-of-line-encoding /usr/share/gems/doc/openshift-origin-dns-bind-0.8.5/ri/Uplift/BindPlugin/keyname-i.ri rubygem-openshift-origin-dns-bind.noarch: W: wrong-file-end-of-line-encoding /usr/share/gems/doc/openshift-origin-dns-bind-0.8.5/ri/cache.ri rubygem-openshift-origin-dns-bind.noarch: W: wrong-file-end-of-line-encoding /usr/share/gems/doc/openshift-origin-dns-bind-0.8.5/ri/Uplift/BindPlugin/server-i.ri rubygem-openshift-origin-dns-bind.noarch: W: wrong-file-end-of-line-encoding /usr/share/gems/doc/openshift-origin-dns-bind-0.8.5/ri/Uplift/BindPlugin/port-i.ri rubygem-openshift-origin-dns-bind.noarch: W: wrong-file-end-of-line-encoding /usr/share/gems/doc/openshift-origin-dns-bind-0.8.5/ri/Uplift/BindPlugin/keyvalue-i.ri rubygem-openshift-origin-dns-bind.noarch: W: unexpanded-macro /usr/share/gems/doc/openshift-origin-dns-bind-0.8.5/ri/Uplift/BindPlugin/namespace_available%3f-i.ri %3f 2 packages and 0 specfiles checked; 0 errors, 6 warnings. All safe to ignore on ruby packages. - package meets naming guidelines - package meets packaging guidelines (ruby) - license (ASL 2.0) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (a996982574791a49c74e422ab2eef3c7510af46c6b0b96fa05d5f3dcefc575e2) - package compiles on devel (noarch) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review