https://bugzilla.redhat.com/show_bug.cgi?id=840037 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |dwmw2@xxxxxxxxxxxxx Component|Package Review |0xFFFF Assignee|nobody@xxxxxxxxxxxxxxxxx |tcallawa@xxxxxxxxxx --- Comment #10 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> --- = REVIEW = - rpmlint checks return: rubygem-openshift-origin-node.src: W: spelling-error Summary(en_US) runtime -> run time, run-time, rudiment rubygem-openshift-origin-node.src: W: spelling-error %description -l en_US sandboxed -> sandboxes, sand boxed, sand-boxed rubygem-openshift-origin-node.src: W: spelling-error %description -l en_US cgroups -> groups, c groups rubygem-openshift-origin-node.src:152: W: macro-in-%changelog %post rubygem-openshift-origin-node.src:152: W: macro-in-%changelog %preun rubygem-openshift-origin-node.noarch: W: spelling-error Summary(en_US) runtime -> run time, run-time, rudiment rubygem-openshift-origin-node.noarch: W: spelling-error %description -l en_US sandboxed -> sandboxes, sand boxed, sand-boxed rubygem-openshift-origin-node.noarch: W: spelling-error %description -l en_US cgroups -> groups, c groups rubygem-openshift-origin-node.noarch: W: hidden-file-or-dir /var/lib/stickshift/.httpd.d rubygem-openshift-origin-node.noarch: W: hidden-file-or-dir /var/lib/stickshift/.httpd.d rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-authorized-ssh-key-add rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-cartridge-list rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary sssh rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-broker-auth-key-add rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-connector-execute rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-app-destroy rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-env-var-remove rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-app-create rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-get-quota rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-env-var-add rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-cartridge-info rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-set-quota rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-trap-user.ruby19 rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-broker-auth-key-remove rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-authorized-ssh-key-remove rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-trap-user rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-app-state-show 2 packages and 0 specfiles checked; 0 errors, 27 warnings. All safe to ignore, but you really should %% comment out those macro references in the changelog. - package meets naming guidelines - package meets packaging guidelines (Ruby) - license (ASL 2.0) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (9ee5ce05a74e0b071a506a31a92e393ba74e359449785c42935e724a7346cf75) - package compiles on devel (noarch) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review