[Bug 845021] Review Request: rubygem-openshift-origin-auth-mongo - OpenShift plugin for mongo authentication service

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=845021

Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |tcallawa@xxxxxxxxxx
              Flags|                            |fedora-review+

--- Comment #17 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> ---
= REVIEW =

- rpmlint returns:
rubygem-openshift-origin-auth-mongo.noarch: W: no-manual-page-for-binary
ss-register-user
rubygem-openshift-origin-auth-mongo-doc.noarch: W: spelling-error
Summary(en_US) mongodb -> mongoloid
rubygem-openshift-origin-auth-mongo-doc.noarch: W: spelling-error %description
-l en_US mongodb -> mongoloid
rubygem-openshift-origin-auth-mongo-doc.noarch: W: unexpanded-macro
/usr/share/gems/doc/openshift-origin-auth-mongo-0.8.5/ri/Swingshift/MongoAuthService/user_exists%3f-i.ri
%3f
rubygem-openshift-origin-auth-mongo-doc.noarch: W:
wrong-file-end-of-line-encoding
/usr/share/gems/doc/openshift-origin-auth-mongo-0.8.5/ri/cache.ri
3 packages and 0 specfiles checked; 0 errors, 5 warnings.

All safe to ignore for ruby packages.

- package meets naming guidelines
- package meets packaging guidelines
- license (ASL 2.0) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
(ebb38a4da9a2edeec5407b0b7492bc7d336b73f3021ae9c854abf65ad611ef2f)
- package compiles on devel (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- doc subpackage OK
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]