https://bugzilla.redhat.com/show_bug.cgi?id=846913 Matěj Cepl <mcepl@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mcepl@xxxxxxxxxx --- Comment #1 from Matěj Cepl <mcepl@xxxxxxxxxx> --- First of all ... it would be prudent to do something about bug 707617 and not just letting it hang there. Legend: + = PASSED, - = FAILED, 0 = Not Applicable - MUST: rpmlint must be run on every package. The output should be posted in the review rpmlint on src.rpm is silent HOWEVER I was not able to rebuilt binary packages neither on my computer or in koji (http://koji.fedoraproject.org/koji/taskinfo?taskID=4371336), so I couldn't test binary packages. I got error: Installed (but unpackaged) file(s) found: /usr/lib64/qt4/imports/Communi/libcommuniplugin.so /usr/lib64/qt4/imports/Communi/qmldir + MUST: package named according to the Package Naming Guidelines + MUST: The spec file name must match the base package %{name} + MUST: The package must meet the Packaging Guidelines . + MUST: The package licensed with a Fedora approved license and meets the Licensing Guidelines + MUST: The License field in the package spec file matches the actual license LGPLv2+ + MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. License file is not included in the upstream package. + MUST: The spec file must be written in American English. + MUST: The spec file for the package MUST be legible. + MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task MD5: 1e6d736d5f212a91fe9f1a6d0926fef5 - MUST: The package successfully compiles and builds into binary rpms on at least one primary architecture - SEE ABOVE 0 MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch + MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines %build part goes on smoothly. 0 MUST: The spec file handles locales properly. This is done by using the %find_lang macro No locales are present. + MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. + MUST: Packages must NOT bundle copies of system libraries 0 MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker + MUST: Package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory + MUST: Package must not list a file more than once in the spec file's %files listings + MUST: Each package must consistently use macros + MUST: The package must contain code, or permissible content 0 MUST: Large documentation files must go in a -doc subpackage 0 MUST: If a package includes something as %doc, it must not affect the runtime of the application + MUST: Header files must be in a -devel package 0 MUST: Static libraries must be in a -static package 0 MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' + MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package + MUST: devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} + MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built 0 MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section + MUST: Packages must not own files or directories already owned by other packages + MUST: All filenames in rpm packages must be valid UTF-8 Please fix FTBFS, otherwise this looks good. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review