[Bug 844192] Review Request: gksu-polkit - Command line utility to run programs as root

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=844192

--- Comment #2 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
Many thanks for your hints. New files:

Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/gksu-polkit.spec
SRPM URL:
http://mariobl.fedorapeople.org/Review/SRPMS/gksu-polkit-0.0.3-2.fc17.src.rpm


(In reply to comment #1)
> - The %post %postun macros are not necessary for the main package but rather
> necessary for the libs package. This should be fixed by changing the lines
> to:
> %post libs -p /sbin/ldconfig
> %postun libs -p /sbin/ldconfig
> 
> - RPMLint gives a binary-or-shlib-defines-rpath error, so I would look into
> disabling rpath via %configure or using chrpath to fix this.

Doing so gives me the following errors:

gksu-polkit-libs.x86_64: E: postun-without-ldconfig
/usr/lib64/libgksu-polkit.so.0.0.1
This package contains a library and its %postun doesn't call ldconfig.

gksu-polkit-libs.x86_64: E: non-empty-%postun /sbin/ldconfig
Scriptlets for the interpreter mentioned in the message should be empty. One
common case where they are unintentionally not is when the specfile contains
comments after the scriptlet and before the next section. Review and clean up
the scriptlet contents if appropriate.


Regarding the FSF address I've informed the upstream developer, CC'ed to you.


Additionally, I've added gtk-doc as a install requirement to the -devel
package. It adds some files to %{_datadir}/gtk-doc/html/ but this folder is
owned by gtk-doc. BTW, there are some more packages on my system which own this
folder:

p11-kit-devel-0.12-1.fc17.x86_64
unique-devel-1.1.6-7.fc17.x86_64
libcanberra-devel-0.28-6.fc17.x86_64
ORBit2-devel-2.14.19-3.fc17.x86_64
libgnome-devel-2.32.1-3.fc17.x86_64
thunarx-python-0.2.3-5.fc17.x86_64
gtk-doc-1.18-2.fc17.noarch
polkit-docs-0.104-6.fc17.noarch
mate-corba-devel-1.4.0-9.fc17.x86_64

I will file some bug reports for them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]