https://bugzilla.redhat.com/show_bug.cgi?id=844192 Jeremy Newton <alexjnewt@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexjnewt@xxxxxxxxxxx --- Comment #1 from Jeremy Newton <alexjnewt@xxxxxxxxxxx> --- Later this week, if I have time I can give this a review if you would like, but here's some misc comments: - You've mixed lines and spaces, which it produces a mixed-use-of-spaces-and-tabs rpmlint error. You should be consistent and only use spaces or tabs for white space separation (you use spaces everywhere except 3 or 4 lines have tabs) - The require on the main package for the libs sub package should be the same as the require on the devel package: "%{name}-libs%{?_isa} = %{version}-%{release}" - The %post %postun macros are not necessary for the main package but rather necessary for the libs package. This should be fixed by changing the lines to: %post libs -p /sbin/ldconfig %postun libs -p /sbin/ldconfig - RPMLint gives a binary-or-shlib-defines-rpath error, so I would look into disabling rpath via %configure or using chrpath to fix this. - There seems to be numerous incorrect-fsf-address errors. I would suggest contacting upstream to let them know about this so they can fix it. A tip would be to make more use of RPMLint (source and binary RPMS) before posting a spec ;) -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review