[Bug 832130] Review Request: cups-filters - OpenPrinting CUPS filters and backends

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=832130

--- Comment #7 from Jiri Popelka <jpopelka@xxxxxxxxxx> ---
(In reply to comment #6)
>  cups-filters.x86_64: I: enchant-dictionary-not-found en_US

This must be a problem on your side.
Maybe installing hunspell-en or aspell-en ?

>  cups-filters.x86_64: E: non-readable /usr/lib/cups/backend/serial 0700L
>  cups-filters.x86_64: E: non-standard-executable-perm
> /usr/lib/cups/backend/serial 0700L

See comment #1. This was already commented in bug #225670, comment #4
(backend/serial used to be part of CUPS).

>  - The package must contain a comment explaining the multiple licensing
> breakdown.

I added a comment.

>  - Compiler used to build probably doesn't honor compiler flags (no use of
> %{optflags} or $RPM_OPT_FLAGS in SPEC file).

Yes, it does. You can see the values of CXXFLAGS/CFLAGS for example here
http://kojipkgs.fedoraproject.org//work/tasks/96/4350096/build.log

I think that you need to use the %{optflags} or $RPM_OPT_FLAGS only if you want
to override them, e.g.
CXXFLAGS="%{optflags} -fno-strict-aliasing" make

I've also added a --disable-silent-rules switch to ./configure so you can see
that the flags
(https://fedoraproject.org/wiki/Packaging:RPMMacros#Build_flags_macros_and_variables)
are really used during building.

>  - Not sure if permissions for "%{_cups_serverbin}/backend/serial" are set
> correctly.

It's ok, see above.


Spec URL: http://jpopelka.fedorapeople.org/cups-filters.spec
SRPM URL: http://jpopelka.fedorapeople.org/cups-filters-1.0.20-3.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]