[Bug 832130] Review Request: cups-filters - OpenPrinting CUPS filters and backends

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=832130

--- Comment #8 from Tomas Hozza <thozza@xxxxxxxxxx> ---
(In reply to comment #7)
> This must be a problem on your side.
> Maybe installing hunspell-en or aspell-en ?

I installed hunspell-en and got the following output for
cups-filters-1.0.20-3.fc17.src.rpm

cups-filters.src: W: spelling-error Summary(en_US) backends -> back ends,
back-ends, backhands
cups-filters.src: W: spelling-error %description -l en_US backends -> back
ends, back-ends, backhands
cups-filters.src: W: spelling-error %description -l en_US centric -> eccentric,
centrist, concentric
cups-filters.src: W: spelling-error %description -l en_US workflow -> work
flow, work-flow, workforce

Please check spelling of these words.

> See comment #1. This was already commented in bug #225670, comment #4
> (backend/serial used to be part of CUPS).

I checked the comment and it's OK.

> 
> I added a comment.

I checked cups-filters-1.0.20-3.fc17 and it is OK now.

> 
> Yes, it does. You can see the values of CXXFLAGS/CFLAGS for example here
> http://kojipkgs.fedoraproject.org//work/tasks/96/4350096/build.log
> 
> I think that you need to use the %{optflags} or $RPM_OPT_FLAGS only if you
> want to override them, e.g.
> CXXFLAGS="%{optflags} -fno-strict-aliasing" make
> 
> I've also added a --disable-silent-rules switch to ./configure so you can
> see that the flags
> (https://fedoraproject.org/wiki/Packaging:
> RPMMacros#Build_flags_macros_and_variables) are really used during building.

You are right, compiler uses proper flags.

> 
> It's ok, see above.

It is OK, as stated above.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]