https://bugzilla.redhat.com/show_bug.cgi?id=832130 --- Comment #6 from Tomas Hozza <thozza@xxxxxxxxxx> --- Review of cups-filters-1.0.20-2.fc17: Legend: "+" means OK, "-" means not OK. - MUST(1): rpmlint must be run on the source rpm and all binary rpms the build produces. + MUST: The package must be named according to the Package Naming Guidelines . + MUST: The spec file name must match the base package %{name}, in the format %{name}.spec. - MUST(2,3): The package must meet the Packaging Guidelines. - MUST(2): The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. + MUST: The License field in the package spec file must match the actual license. + MUST: If the source package includes the text of the license(s) in its own file, then that file must be included in %doc. + MUST: The spec file must be written in American English. + MUST: The spec file for the package MUST be legible. + MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. + MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. + MUST: All build dependencies must be listed in BuildRequires. + MUST: The spec file MUST handle locales properly.he %find_lang macro. + MUST: Every binary RPM package (or subpackage) which stores shared library files in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. + MUST: Packages must NOT bundle copies of system libraries. + MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. + MUST: A package must own all directories that it creates. + MUST: A Fedora package must not list a file more than once in the spec file's %files listings. - MUST(4): Permissions on files must be set properly. + MUST: Each package must consistently use macros. + MUST: The package must contain code, or permissable content. + MUST: Large documentation files must go in a -doc subpackage. + MUST: If a package includes something as %doc, it must not affect the runtime of the application. + MUST: Static libraries must be in a -static package. + MUST: Development files must be in a -devel package. + MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency. + MUST: Packages must NOT contain any .la libtool archives. + MUST: Packages containing GUI applications must include a %{name}.desktop file. + MUST: Packages must not own files or directories already owned by other packages. + MUST: All filenames in rpm packages must be valid UTF-8. 1: RPMLINT check of binary RPMs: cups-filters.x86_64: I: enchant-dictionary-not-found en_US cups-filters.x86_64: E: non-readable /usr/lib/cups/backend/serial 0700L cups-filters.x86_64: E: non-standard-executable-perm /usr/lib/cups/backend/serial 0700L cups-filters-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 2 errors, 1 warnings. RPMLINT check of SRPM: cups-filters.src: I: enchant-dictionary-not-found en_US 1 packages and 0 specfiles checked; 0 errors, 0 warnings. 2: - The package must contain a comment explaining the multiple licensing breakdown. Check https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios for more info. 3: - Compiler used to build probably doesn't honor compiler flags (no use of %{optflags} or $RPM_OPT_FLAGS in SPEC file). Check https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags for more info. 4: - Not sure if permissions for "%{_cups_serverbin}/backend/serial" are set correctly. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review