Bug 225882: Merge Review: hdparm Product: Fedora Extras Version: devel Component: Package Review manuel wolfshant <wolfy@xxxxxxxxxxxxxxxxxx> has denied manuel wolfshant <wolfy@xxxxxxxxxxxxxxxxxx>'s request for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225882 ------- Additional Comments from manuel wolfshant <wolfy@xxxxxxxxxxxxxxxxxx> - BuildRoot is not the preferred value - %build does not use smp flags; if not supported, please add a comment in the spec - please also consider including README.accoustic; the feature is documented in the man page, but the README seems to include a bit more info The rest seems OK. Please fix the above and I'll do a full review. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review