Bug 225625: Merge Review: bridge-utils Product: Fedora Extras Version: devel Component: Package Review Jima <jima@xxxxxxxxxxxxxx> has asked for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225625 ------- Additional Comments from Jima <jima@xxxxxxxxxxxxxx> Review time! :-) OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 43bbd2a67b59cac3e15d545f8b51df68 bridge-utils-1.1.tar.gz 43bbd2a67b59cac3e15d545f8b51df68 bridge-utils-1.1.tar.gz.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. See below - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag See below - Should package latest version 2 bugs - check for outstanding bugs on package. Issues: 1. The recommended value for BuildRoot is: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) You may want to use that. 2. rpmlint says: rpmlint on ./bridge-utils-1.1-2.fc7.src.rpm W: bridge-utils setup-not-quiet E: bridge-utils no-cleaning-of-buildroot %install Easily fixed. Add -q to %setup, and "rm -rf $RPM_BUILD_ROOT" after %install. 3. Latest version not used http://sourceforge.net/project/showfiles.php?group_id=26089 says 1.2 is available (and has been since 2006-09-20). Please evaluate whether you should be using this release instead. 4. Bugs open There are two open bugs against this package: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205810 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169723 I'm not sure either bug is still particularly valid (one is against FC4, the other looks like it should be resolved). If you can address the issues above, I think we can call bridge-utils APPROVED. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review