Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: hdparm https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225882 wolfy@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO AssignedTo|nobody@xxxxxxxxxxxxxxxxx |karsten@xxxxxxxxxx Flag| |fedora-review-, needinfo? ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-02-09 09:18 EST ------- - BuildRoot is not the preferred value - %build does not use smp flags; if not supported, please add a comment in the spec - please also consider including README.accoustic; the feature is documented in the man page, but the README seems to include a bit more info The rest seems OK. Please fix the above and I'll do a full review. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review