https://bugzilla.redhat.com/show_bug.cgi?id=834070 --- Comment #4 from Jose Pedro Oliveira <jpo@xxxxxxxxxxxx> --- (In reply to comment #3) > (In reply to comment #1) > > Daryl, > > > > This is quick first review: > > > > Blocker: > > * The tarball isn't published by the upstream project [1]. > > > > A note in the specfile explaining how it is generated should be imperative > > so that the source files can be verified. > > (although I believe it's a subset of the main qpid-0.16 tarball). > > I'm on the upstream team. We're going to be publishing the Perl sources > separately with an upcoming release. Previously the Perl bindings were a > part of our monolithic qpid-cpp package but we want to break it out to be > its own package. Great. The current installation Perl procedure was broken, or to be fair, the current uninstallation procedure was broken as there is no reliable way to remove a perl module via ExtUtils::Makemaker. Will this tarball split be in place for the 0.18 beta? The qpid-perl tarball isn't available in the 0.18 alpha release (https://people.apache.org/~jross/qpid-0.18-alpha/). > > This is now noted in the specfile. > > * contact the perl bindings author so that the patch in the upstream ticket > > QPID-3313 [2] can be applied (see comments in the upstream ticket) > > I'll take care of this after the package finishes review. I wouldn't want to > introduce patches to the process at this point. I've already tried to have it committed for qpid 0.14 but the patch author (who also made the Qpid perl bindings) forgot to check the license checkbox :( > > > > > > > Regards, > > jpo > > > > [1] - https://www.apache.org/dyn/closer.cgi/qpid/0.16/ > > [2] - Update example scripts for perl binding. > > https://issues.apache.org/jira/browse/QPID-3313 > > > New SPEC: http://mcpierce.fedorapeople.org/rpms/perl-qpid.spec > New SRPM: > http://mcpierce.fedorapeople.org/rpms/perl-qpid-0.16-1.fc17.1.src.rpm Blocker: * The change from "%{perl_vendorarch}/*" to "%{perl_vendorarch}" is a blocker as it makes the perl-qpid package own the perl_vendorarch directory. Note: * You no longer need to add a defattr line to the %files section The %files section can be something like: ------ %files %doc LICENSE examples/ %{perl_vendorarch}/* %exclude %dir %{perl_vendorarch}/auto/ ------ * any particular reason why the release bump was not 2.fc17? /jpo -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review