https://bugzilla.redhat.com/show_bug.cgi?id=834070 --- Comment #3 from Darryl L. Pierce <dpierce@xxxxxxxxxx> --- (In reply to comment #1) > Daryl, > > This is quick first review: > > Blocker: > * The tarball isn't published by the upstream project [1]. > > A note in the specfile explaining how it is generated should be imperative > so that the source files can be verified. > (although I believe it's a subset of the main qpid-0.16 tarball). I'm on the upstream team. We're going to be publishing the Perl sources separately with an upcoming release. Previously the Perl bindings were a part of our monolithic qpid-cpp package but we want to break it out to be its own package. This is now noted in the specfile. > Minor: > * Remove the comments in the %build and %install sections: this a binary RPM > and not a noarch one (and perl packagers should be able to review either > type). Done. > * There is a empty %doc line in the %files section Done > > Wishlist: > * ship the examples as documentation files > (%doc examples/) Done. > * contact the perl bindings author so that the patch in the upstream ticket > QPID-3313 [2] can be applied (see comments in the upstream ticket) I'll take care of this after the package finishes review. I wouldn't want to introduce patches to the process at this point. > > > Regards, > jpo > > [1] - https://www.apache.org/dyn/closer.cgi/qpid/0.16/ > [2] - Update example scripts for perl binding. > https://issues.apache.org/jira/browse/QPID-3313 New SPEC: http://mcpierce.fedorapeople.org/rpms/perl-qpid.spec New SRPM: http://mcpierce.fedorapeople.org/rpms/perl-qpid-0.16-1.fc17.1.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review