[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=834070

--- Comment #5 from Darryl L. Pierce <dpierce@xxxxxxxxxx> ---
(In reply to comment #4)
> Great. The current installation Perl procedure was broken, or to be fair,
> the current uninstallation procedure was broken as there is no reliable way
> to remove a perl module via ExtUtils::Makemaker.
> 
> Will this tarball split be in place for the 0.18 beta?  The qpid-perl tarball
> isn't available in the 0.18 alpha release
> (https://people.apache.org/~jross/qpid-0.18-alpha/).

I don't think so. I have a patch set that's pending review still in JIRA, but
our 0.18 alpha has already been cut. Since this isn't critical path for 0.18,
it'll likely be a part of our 0.20 release.

> > This is now noted in the specfile.
> 
> 
> > >  * contact the perl bindings author so that the patch in the upstream ticket
> > >    QPID-3313 [2] can be applied (see comments in the upstream ticket)
> > 
> > I'll take care of this after the package finishes review. I wouldn't want to
> > introduce patches to the process at this point.
> 
> I've already tried to have it committed for qpid 0.14 but the patch author
> (who also made the Qpid perl bindings) forgot to check the license checkbox
> :(

Understood. I'll make it a priority post-review. :)

> > > Regards,
> > > jpo
> > > 
> > > [1] - https://www.apache.org/dyn/closer.cgi/qpid/0.16/
> > > [2] - Update example scripts for perl binding.
> > >       https://issues.apache.org/jira/browse/QPID-3313
> > 
> > 
> > New SPEC: http://mcpierce.fedorapeople.org/rpms/perl-qpid.spec
> > New SRPM:
> > http://mcpierce.fedorapeople.org/rpms/perl-qpid-0.16-1.fc17.1.src.rpm
> 
> Blocker:
> 
>  * The change from "%{perl_vendorarch}/*" to "%{perl_vendorarch}" is a
> blocker
>    as it makes the perl-qpid package own the perl_vendorarch directory.

Derp! Sorry, I didn't realize I'd removed the splat.

> 
> Note:
> 
>  * You no longer need to add a defattr line to the %files section
>    The %files section can be something like:
>    ------
>    %files
>    %doc LICENSE examples/
>    %{perl_vendorarch}/*
>    %exclude %dir %{perl_vendorarch}/auto/
>    ------
> 
>  * any particular reason why the release bump was not 2.fc17? 
> 
> /jpo

Since we're only modifying the specfile and not the underlying code, I'm only
treating these as point releases on the spec.

Updated SPEC: http://mcpierce.fedorapeople.org/rpms/perl-qpid.spec
Updated SRPM:
http://mcpierce.fedorapeople.org/rpms/perl-qpid-0.16-1.fc17.2.src.rpm

Thank you. :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]