[Bug 833511] Review Request: dnf - A Yum fork on top of libsolv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=833511

--- Comment #3 from Terje Røsten <terjeros@xxxxxxxxxxxx> ---
Thanks, some more items.

- seems to mix tab and whitespace
- this is two buildrequires on one line: BuildRequires:    cmake python2 :-)
- file listing is recursive by default and you need to own the dir itself,
change 
   %{python_sitelib}/dnf/* to  %{python_sitelib}/dnf/
- with only %config(noreplace) %{confdir}/dnf.conf,  %{confdir} ends up
unowned, add
 a %dir  %{confdir} line to file listing.
- use %global not %define
- still %dist in changelogs?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]