https://bugzilla.redhat.com/show_bug.cgi?id=833511 --- Comment #2 from Ales Kozumplik <akozumpl@xxxxxxxxxx> --- New spec and srpm: http://akozumpl.fedorapeople.org/review/dnf_2/dnf.spec http://akozumpl.fedorapeople.org/review/dnf_2/dnf-0.2.6-8.gitb4aa5c1.fc17.noarch.rpm (In reply to comment #1) > Some initial comments: > > - provide full url to source tarball please Done. > - %description and Summary needs some work (people don't know what yum is) Improved. > - more explicit file listing would bbe nice That's what I would like to avoid, the current listing is concise and safe as far as I know. Or does the package have some files it shouldn't? Should I name every python source explicitly? Updated /usr/bin/* to /usr/bin/dnf. > - split buildreq into separate lines Hm, I only have one buildreq.. > - some kind of documentation would be great :-) Coming up, not just right yet. I plan to ship this into F18 with documentation (a man page for 'dnf' at least). > - drop the %dist thing in changelog? Done. > - why is cmake used over setup.py? The reason is cmake is used in libsolv, I use it in hawkey (the glue between libsolv and DNF) and here I use it to be consistent accross the stack. And it works pretty well for DNF too (and once i18n comes in I am sure cmake can handle it fine too). -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review