https://bugzilla.redhat.com/show_bug.cgi?id=833511 --- Comment #4 from Ales Kozumplik <akozumpl@xxxxxxxxxx> --- Uploaded next version: http://akozumpl.fedorapeople.org/review/dnf_3/dnf.spec http://akozumpl.fedorapeople.org/review/dnf_3/dnf-0.2.6-9.gitb4aa5c1.fc17.src.rpm (In reply to comment #3) > Thanks, some more items. > > - seems to mix tab and whitespace What line? I thought rpmlint catches this but mine is silent about this. > - this is two buildrequires on one line: BuildRequires: cmake python2 :-) Ah, yes, thanks. > - file listing is recursive by default and you need to own the dir itself, > change > %{python_sitelib}/dnf/* to %{python_sitelib}/dnf/ > - with only %config(noreplace) %{confdir}/dnf.conf, %{confdir} ends up > unowned, add > a %dir %{confdir} line to file listing. Fixed, thanks. > - use %global not %define Done. > - still %dist in changelogs? Sorry about that, I sent the wrong file version, should be fine now. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review