Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: pycairo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226329 roozbeh@xxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|roozbeh@xxxxxxxxxxxxx |mbarnes@xxxxxxxxxx Flag|fedora-review? |fedora-review- ------- Additional Comments From roozbeh@xxxxxxxxxxxxx 2007-02-06 09:18 EST ------- More necessary and suggested changes: * You forgot to change the BuildRoot * License is actually LGPL/MPL, while the License field only says LGPL. (BLOCKER) * The description and the summary field say exactly the same thing. Expand the description field. * I do not know about the specifics of the dependency on cairo, but are you sure the dependency is actually >= 1.2.6 and not = 1.2.6? * The extra info "-n pycairo-%{version}" is not necessary, as the tarball gets unpacked to the same directory anyway. Just use "%setup -q". * You should not use .fc7 and such in %changelog comments (unless your change is only for that version of Fedora, which is not the case here) I believe that is all, but I have not done a check-list check yet. Will do that as soon as you fix these. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review