Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: tar https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226478 ------- Additional Comments From bugs.michael@xxxxxxx 2007-02-06 09:20 EST ------- tar-1.16.1.tar.bz2 plus sig is available upstream. > Prereq: info Requires(post): /sbin/install-info Requires(preun): /sbin/install-info > %makeinstall bindir=$RPM_BUILD_ROOT/bin libexecdir=$RPM_BUILD_ROOT/sbin Standard make install with DESTDIR ought to be preferred, provided that it works: make DESTDIR=$RPM_BUILD_ROOT bindir=/bin libexecdir=/sbin install The %makeinstall macro overrides many Make variables, which can lead to %buildroot finding its way into built files. > install -c -m Wherever files are installed manually, add option "-p" to preserve time-stamps, so files which haven't changed for a long time are easier to spot when browsing installed package contents. > BuildRoot: ... Doesn't match the Fedora standard %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) and might be rejected as soon as it might become mandatory. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review