Bug 226329: Merge Review: pycairo Product: Fedora Extras Version: devel Component: Package Review Roozbeh Pournader <roozbeh@xxxxxxxxxxxxx> has denied Roozbeh Pournader <roozbeh@xxxxxxxxxxxxx>'s request for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226329 ------- Additional Comments from Roozbeh Pournader <roozbeh@xxxxxxxxxxxxx> More necessary and suggested changes: * You forgot to change the BuildRoot * License is actually LGPL/MPL, while the License field only says LGPL. (BLOCKER) * The description and the summary field say exactly the same thing. Expand the description field. * I do not know about the specifics of the dependency on cairo, but are you sure the dependency is actually >= 1.2.6 and not = 1.2.6? * The extra info "-n pycairo-%{version}" is not necessary, as the tarball gets unpacked to the same directory anyway. Just use "%setup -q". * You should not use .fc7 and such in %changelog comments (unless your change is only for that version of Fedora, which is not the case here) I believe that is all, but I have not done a check-list check yet. Will do that as soon as you fix these. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review