[Bug 820729] Review Request: mingw-cximage - MinGW Windows CxImage manipulation library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Comment # 5 from
(In reply to comment #4)
> Please bump the release tag in the .spec file every time you make a change
> instead of replacing the old version. This makes it harder to compare
> revisions

ok, didn't know about that

> I just took a look at the debug issue. It seems to be caused by the fact
> that some RPM variables aren't set automatically as you don't have a %setup
> tag in the %prep section. It is possible to use this tag without having it
> trying to extract source files. You can try to add these lines just after
> the 7za command:
> cd ..
> %setup -q -T -D -n %{name}-%{version}
> 
> With this change, some of the 'cd' calls in other sections can be removed as
> they're unneeded

Indeed, works, thanks

> 
> In your original .spec file you tried to install the .dll files to libdir
> and name it .dll.a, but that isn't going to work. In your latest .spec file
> you already seem to have resolved this issue and also made it generate an
> import library which is good. Your original .spec file also missed an
> %{?mingw_debug_package} line, but you seem to have added this in your latest
> spec file. Again, please bump the release tag and publish a new .src.rpm
> every time you make a change

hmm, I guess that was an outdated srpm.

Fixed ones uploaded:

http://elmarco.fedorapeople.org/mingw-cximage.spec
http://elmarco.fedorapeople.org/mingw-cximage-600-4.fc17.src.rpm


You are receiving this mail because:
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]