https://bugzilla.redhat.com/show_bug.cgi?id=820729 Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #6 from Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> --- $ rpmlint mingw-cximage.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint mingw-cximage-600-4.fc17.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint mingw32-cximage-600-4.fc17.noarch.rpm mingw32-cximage-static-600-4.fc17.noarch.rpm mingw64-cximage-600-4.fc17.noarch.rpm mingw64-cximage-static-600-4.fc17.noarch.rpm mingw32-cximage.noarch: W: no-documentation mingw32-cximage-static.noarch: W: no-documentation mingw64-cximage.noarch: W: no-documentation mingw64-cximage-static.noarch: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 4 warnings. $ rpm --query --requires mingw32-cximage mingw32(gdi32.dll) mingw32(kernel32.dll) mingw32(libgcc_s_sjlj-1.dll) mingw32(libjasper-1.dll) mingw32(libjpeg-62.dll) mingw32(libpng15-15.dll) mingw32(libstdc++-6.dll) mingw32(libtiff-3.dll) mingw32(msvcrt.dll) mingw32(user32.dll) mingw32-crt mingw32-filesystem >= 83 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw64-cximage mingw64(gdi32.dll) mingw64(kernel32.dll) mingw64(libgcc_s_sjlj-1.dll) mingw64(libjasper-1.dll) mingw64(libjpeg-62.dll) mingw64(libpng15-15.dll) mingw64(libstdc++-6.dll) mingw64(libtiff-3.dll) mingw64(msvcrt.dll) mingw64(user32.dll) mingw64-crt mingw64-filesystem >= 83 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --provides mingw32-cximage mingw32(libcximage.dll) mingw32-cximage = 600-4.fc17 $ rpm --query --provides mingw64-cximage mingw64(libcximage.dll) mingw64-cximage = 600-4.fc17 $ wget --quiet http://sourceforge.net/projects/cximage/files/6.00/cximage600_full.7z -O - | md5sum 7c5141120cc849308f96702ce8e3c0eb - $ md5sum cximage600_full.7z 7c5141120cc849308f96702ce8e3c0eb cximage600_full.7z + OK ! Needs to be looked into / Not applicable [!] Compliant with generic Fedora Packaging Guidelines [+] Source package name is prefixed with 'mingw-' [+] Spec file starts with %{?mingw_package_header} [+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file [+] BuildRequires: mingw64-filesystem >= 95 is in the .spec file [+] Spec file contains %package sections for both mingw32 and mingw64 packages [+] Binary mingw32 and mingw64 packages are noarch [+] Spec file contains %{?mingw_debug_package} after the %description section [!] Uses one of the macros %mingw_configure, %mingw_cmake, or %mingw_cmake_kde4 to configure the package [!] Uses the macro %mingw_make to build the package [!] Uses the macro %mingw_make to install the package [/] If package contains translations, the %mingw_find_lang macro must be used [+] No binary package named mingw-$pkgname is generated [+] Libtool .la files are not bundled [+] .def files are not bundled [+] Man pages which duplicate native package are not bundled [+] Info files which duplicate native package are not bundled [+] Provides of the binary mingw32 and mingw64 packages are equal [+] Requires of the binary mingw32 and mingw64 packages are equal The license isn't bundled with this package yet. Please include this (CxImage/license.txt) and mark this as %doc before importing the package in Fedora The .spec file currently doesn't use one of the RPM macros %mingw_configure, %mingw_cmake, %mingw_cmake_kde4 or %mingw_make. As the upstream package only provides MSVC based project files and the library itself is quite small it's okay to use custom gcc calls to build this package This package is using cximage 6.00 (released in december 2010) while the latest available version is 7.02 (released in february 2011). You might want to consider to update to this latest version =================================================== The package mingw-cximage is APPROVED by epienbro =================================================== -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review