[Bug 820729] Review Request: mingw-cximage - MinGW Windows CxImage manipulation library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Comment # 4 from
Please bump the release tag in the .spec file every time you make a change
instead of replacing the old version. This makes it harder to compare revisions

I just took a look at the debug issue. It seems to be caused by the fact that
some RPM variables aren't set automatically as you don't have a %setup tag in
the %prep section. It is possible to use this tag without having it trying to
extract source files. You can try to add these lines just after the 7za
command:
cd ..
%setup -q -T -D -n %{name}-%{version}

With this change, some of the 'cd' calls in other sections can be removed as
they're unneeded

In your original .spec file you tried to install the .dll files to libdir and
name it .dll.a, but that isn't going to work. In your latest .spec file you
already seem to have resolved this issue and also made it generate an import
library which is good. Your original .spec file also missed an
%{?mingw_debug_package} line, but you seem to have added this in your latest
spec file. Again, please bump the release tag and publish a new .src.rpm every
time you make a change


You are receiving this mail because:
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]