Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: moto4lin - Filemanager and seem editor for Motorola P2k phones https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227256 wolfy@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED OtherBugsDependingO|163776 |163778 nThis| | Flag| |fedora-review- ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-02-04 07:03 EST ------- MUSTFIX: Missing SMP flags: if there is a known problem, a comment should be added in the spec file (wiki: PackagingGuidelines#parallelmake) You should not use the Packager tag (wiki: PackagingGuidelines#tags) Does not build in mock (missing qmake), you should add a Buildrequire for qt-devel. Minor: BuildRoot does not follow the guidelines (should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review