Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: which https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226539 ruben@xxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|ruben@xxxxxxxxxxxxxxxx |than@xxxxxxxxxx CC| |ruben@xxxxxxxxxxxxxxxx Flag|fedora-review? |fedora-review- ------- Additional Comments From ruben@xxxxxxxxxxxxxxxx 2007-02-04 06:53 EST ------- Review for release 8: * RPM name is OK * Source which-2.16.tar.gz is the same as upstream * This is the latest version * Builds fine in mock * File list looks OK Needs work: * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) * Missing SMP flags. If it doesn't build with it, please add a comment (wiki: PackagingGuidelines#parallelmake) * The %makeinstall macro should not be used (wiki: PackagingGuidelines#MakeInstall) * The package should contain the text of the license (wiki: Packaging/ReviewGuidelines) COPYING is included in the source, please add it to %doc * Please change hardcoded paths with macro's * Preserve timestamps when installing files * Please consider using {?dist} in the Release Tag (http://fedoraproject.org/wiki/DistTag) Rpmlint is not silent: Source RPM: W: which summary-ended-with-dot Displays where a particular program in your path is located. W: which strange-permission which-2.sh 0775 W: which redundant-prefix-tag W: which prereq-use /sbin/install-info W: which prereq-use dev Use Requires(post) and Requires(preun). What's the prereq dev for? rpmlint of which: W: which summary-ended-with-dot Displays where a particular program in your path is located. W: which conffile-without-noreplace-flag /etc/profile.d/which-2.sh E: which executable-marked-as-config-file /etc/profile.d/which-2.sh E: which executable-sourced-script /etc/profile.d/which-2.sh 0755 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review