Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: GshutDown - Advanced shut down utility for GNOME https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227228 ------- Additional Comments From cgoorah@xxxxxxxxxxxx 2007-02-04 07:09 EST ------- Easy Fix: chitlesh(SPECS)[1]$rpmlint /home/chitlesh/rpmbuild/SRPMS/gshutdown-0.2-1.rc1.src.rpm W: gshutdown mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 2) You should add timestamps to your make install: %{__make} DESTDIR=%{buildroot} INSTALL="%{__install} -p" install version labeling: Version: 0.2 Release: 1.rc1%{?dist} you should pretty much do: Version: 0.2rc1 Release: 1%{?dist} You can dropped explicit BR: BuildRequires: gtk2-devel, libglade2-devel Since chitlesh(devel)[0]$rpm -qR libglade2-devel /usr/bin/python gtk2-devel >= 2.5.0 libglade-2.0.so.0 [...] libglade2-devel already requires gtk2-devel You can dropped this as well --add-category X-Fedora \ The file NEWS is useless, you also dropped it as its contents refers to ChangeLog Also there is no use of writing explicit requires such: Requires: libglade >= 0.17, libnotify >= 0.4.2 yum will search for them automatically. :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review