Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=817981 --- Comment #3 from Jerry James <loganjerry@xxxxxxxxx> 2012-05-07 13:25:34 EDT --- Just a few more issues, I think. The build system is adding -fomit-frame-pointer to the compiler flags, which should not be done: https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags. Also, the shared library has a number of undefined non-weak symbols which would be satisfied by linking with libgmp, as well as two symbols (ceil and floor) that would be satisfied by linking with libm. To see this, install ratpoints, then run "rpmlint ratpoints". In addition, the shared library is not linked with RPM_LD_FLAGS, which enables partial relro. To fix all of the above, add this to %prep and drop CCFLAGS="..." from the make invocation in %build: sed -e "s/-Wall -O2 -fomit-frame-pointer/%{optflags} %{use_sse}/" \ -e "s/-shared/& $RPM_LD_FLAGS -lgmp -lm/" \ -i Makefile Also, gpl-2.0.txt should be in %doc: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text. Finally, is there any reason that multi-lib would be helpful? That's when, on x86_64 for example, you can install both i686 and x86_64 versions of the library. (You only get the x86_64 version of the binary, though.) If that would be useful, then you should put the binary and the library into separate packages. This can be done either way: the main package contains the library and a subpackage (say, -tools) contains the binary, or the main package contains the binary and a subpackage (say, -libs) contains the library. In either case, make sure the binary subpackage requires the library subpackage. Catering to multi-lib is not required. I'm just bringing it up in case you consider it a good thing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review