Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=817981 --- Comment #4 from pcpa <paulo.cesar.pereira.de.andrade@xxxxxxxxx> 2012-05-07 23:39:25 EDT --- Many thanks for the review. I added verbatim your suggestions to correct the issues you pointed out in the Makefile. Also added gpl-2.0.txt to the main package. I agree about the point of multilib, besides I myself do not use it and always purge ix86 rpms :-) I think I would go with the -tools suggestion. But I am used to do it in Mandriva by creating a library package, in this case, it would be: ratpoints libratpoints0 libratpoints-devel but in Mandriva I had packaged all in one, because there is only one header, one small library and one small binary... I think better to keep things simple for now :-) As a lot of other things would break if pretending to install sagemath i686 and x86_64 in the same system. rpmlint output: $ rpmlint SRPMS/ratpoints-2.1.3-3.fc16.src.rpm RPMS/x86_64/ratpoints-* ratpoints.src: W: spelling-error Summary(en_US) hyperelliptic -> hyper elliptic, hyper-elliptic, hypercritical ratpoints.src: W: spelling-error %description -l en_US hyperelliptic -> hyper elliptic, hyper-elliptic, hypercritical ratpoints.x86_64: W: spelling-error Summary(en_US) hyperelliptic -> hyper elliptic, hyper-elliptic, hypercritical ratpoints.x86_64: W: spelling-error %description -l en_US hyperelliptic -> hyper elliptic, hyper-elliptic, hypercritical ratpoints-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 5 warnings. and rpmlint on installed package: $ rpmlint ratpoints ratpoints-devel ratpoints.x86_64: W: spelling-error Summary(en_US) hyperelliptic -> hyper elliptic, hyper-elliptic, hypercritical ratpoints.x86_64: W: spelling-error %description -l en_US hyperelliptic -> hyper elliptic, hyper-elliptic, hypercritical ratpoints.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libratpoints.so.0 linux-vdso.so.1 ratpoints-devel.x86_64: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 4 warnings. also tested a koji --scratch build and it finishes without errors. Updated spec and srpm at: Spec URL: http://kenobi.mandriva.com/~pcpa/ratpoints.spec SRPM URL: http://kenobi.mandriva.com/~pcpa/ratpoints-2.1.3-3.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review