[Bug 817981] Review Request: ratpoints - Find rational points on hyperelliptic curves

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=817981

--- Comment #2 from pcpa <paulo.cesar.pereira.de.andrade@xxxxxxxxx> 2012-05-04 21:10:24 EDT ---
  I had updated the spec to handle sse in %{ix86} like this, in %build:

%ifarch %{ix86}
mkdir sse2
mv -f libratpoints.so.%{major} sse2
rm -f libratpoints.so
make clean
make %{?_smp_mflags} CCFLAGS="%{optflags}"
%endif

in %install

%ifarch %{ix86}
mv sse2 $RPM_BUILD_ROOT%{_libdir}
%endif

and in %files

%ifarch %{ix86}
%{_libdir}/sse2/libratpoints.so.%{major}
%endif

and also added to %changelog
- Build with and without sse2 support on ix86.


but, then, after ensuring everything was correct in a koji --scratch build,
I did a last review, to find this in ratpoints-2.1.3/rp-private.h:

/* Check if SSE instructions can be used.
   We assume that one SSE word of 128 bit is two long's,
   so check that a long is 64 bit = 8 byte.
*/
#ifndef __SSE2__
#undef USE_SSE
#endif
#if __WORDSIZE != 64
#undef USE_SSE
#endif


I failed :-) So I changed to only enable sse2 on x86_64

Updated spec and srpm at:

Spec URL: http://kenobi.mandriva.com/~pcpa/ratpoints.spec
SRPM URL: http://kenobi.mandriva.com/~pcpa/ratpoints-2.1.3-2.fc16.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]